export type ModelDataMinimal #1035
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mishig25
requested review from
SBrandeis,
Wauplin,
gary149,
julien-c,
ngxson and
pcuenca
as code owners
julien-c
reviewed
Nov 15, 2024
Member
julien-c
left a comment
julien-c
left a comment
There was a problem hiding this comment.
this is a bit weird bc ModelData is originally in moon-landing, so it's weird/cyclical to re-import a partial copy of it
I'd rather redefine it in moon-landing in some way
Collaborator
Author
|
yeah indeed, that would be better |
Member
|
JFI it's already exported as part of #1026 via (at least it should be) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
export type ModelDataMinimal because it is needed in moon